[PATCH v3 06/16] Prefer gpg2 in the test suite if available

[Tomi Ollila]

On Wed, Feb 10 2016, Daniel Kahn Gillmor <dkg at fifthhorseman.net> wrote:

> On Wed 2016-02-10 06:54:12 -0500, David Bremner wrote:
>> Daniel Kahn Gillmor <dkg at fifthhorseman.net> writes:
>>
>>>  
>>> +# choose the preferred GnuPG binary:
>>> +if command -v gpg2 > /dev/null; then
>>> +    GPG=gpg2
>>> +else
>>> +    GPG=gpg
>>> +fi
>>
>> It feels like this should maybe be in configure, to centralize the choice
>> of GPG default. At least, that would be consistent with python / python2
>
> I'm not sure what to do here.  Ultimately, i don't want there to be a
> choice because i plan on having /usr/bin/gpg provided by gpg2, so this
> will all be moot.

Code searches through PATH, so IMO this test could do the same (with
reasonable similarity (like above)). This could add check whether GPG
is already defined that definition is used...


>
> So i'm not inclined to spend much more time/engineering effort on it,
> but if someone wants to propose moving these choices into configure, i'd
> be willing to review.
>
>    --dkg