[PATCH 1/3] emacs: Fix mail composition under Emacs 23

[Michal Sojka]

On Tue, Jan 05 2016, David Bremner wrote:
> Michal Sojka <sojkam1 at fel.cvut.cz> writes:
>
>> +    (when return-action (nconc args '(return-action)))
>> +    (apply 'message-setup-1
>> +	   ;; The following sexp is copied from `message-mail'
>
>> +	   (nconc
>> +	    `((To . ,(or to "")) (Subject . ,(or subject "")))
>
> I missed this the first time, but I a bit worried about this used of
> nconc. It seems to fall under "A common pitfall is to use a quoted
> constant list as a non-last argument to ‘nconc’"  (from the elisp
> manual).  In any case it's not really performance critical code (I
> guess?) so maybe we could just use append?

Yes, this make sense. As the nconc is already in master, I'll not
combine the fix for this with 1/3, but I'm sending a separate patch that
applies after 3/3.

-Michal