[PATCH v4 0/7] emacs: Improve the cited message included in replies

Mark Walters markwalters1009 at gmail.com
Sat Nov 7 03:04:29 PST 2015


This is a rebase and somewhat tweaked version of dme's series from last year
id:1399897769-26809-1-git-send-email-dme at dme.org

One particular motivation for this series is that it fixes a long
standing bug we have that replying to a message with an rfc822 part
completely omits that part. It also fixes the bug whereby we don't
include application/octet-stream parts which are actually text/plain
(and thus are displayed in show mode).

This series makes the reply code use the same code as the show code so
everything works as expected: the reply buffer looks essentially the
same as the show buffer.

There is one slight difference: the user might want different part
headers displayed when replying; both because the audience is
different (a non-notmuch using recipient) and because the buttons
don't "work" (you can't click on them to show or view a part).

Dme and I disagree on which of these we would like to see so make that
customisable.

The key change is patch 3 which switches how reply works. Also note
that patch 2 is almost all whitespace change as the changes modify the
indentation.

Best wishes

Mark


David Edmondson (6):
  emacs/show: Re-arrange determination if a part header is necessary
  emacs/show: Accommodate the lack of part header buttons
  emacs/mua: Generate improved cited text for replies
  emacs/show: Remove the 'no-buttons option of
    `notmuch-show-insert-bodypart'
  emacs/show: Make the insertion of part headers overridable.
  emacs/mua: Let user specify which parts get a header in citations.

Mark Walters (1):
  test: fix the tests for the new reply code

 emacs/notmuch-mua.el  |  60 ++++++++++-----------
 emacs/notmuch-show.el | 141 +++++++++++++++++++++++++++++++-------------------
 test/T310-emacs.sh    |  32 ++++++++++++
 test/test-lib.el      |   4 ++
 4 files changed, 155 insertions(+), 82 deletions(-)

-- 
2.1.4



More information about the notmuch mailing list