[PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default

Tomi Ollila tomi.ollila at iki.fi
Fri Sep 11 13:44:11 PDT 2015


make test V=1 (or any other value than 0) and make test V=0
works similar way as build in general
---

This is 2nd try: In first one I changed test-lib.sh -- there problem
was the precedence between command line argument and NOTMUCH_TEST_QUIET
environment variable. Here I don't see a problem there (although
env NOTMUCH_TEST_QUIET=1 make test V=1 will make environment variable
overrule the V=1 -- I am not sure who cares, though :D)

Anyway, Someone(TM) may have better solution in mind, so let's
get bikeshedding going!

 test/Makefile.local | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/test/Makefile.local b/test/Makefile.local
index 2331ceb..2b18691 100644
--- a/test/Makefile.local
+++ b/test/Makefile.local
@@ -56,7 +56,17 @@ TEST_BINARIES := $(TEST_BINARIES:.cc=)
 test-binaries: $(TEST_BINARIES)
 
 test:	all test-binaries
+ifeq ($V,)
+	@echo 'Use "$(MAKE) V=1" to print test headings and PASSIng results.'
+	@env NOTMUCH_TEST_QUIET=1 ${test_src_dir}/notmuch-test $(OPTIONS)
+else
+# The user has explicitly enabled quiet execution.
+ifeq ($V,0)
+	@env NOTMUCH_TEST_QUIET=1 ${test_src_dir}/notmuch-test $(OPTIONS)
+else
 	@${test_src_dir}/notmuch-test $(OPTIONS)
+endif
+endif
 
 check: test
 
-- 
2.4.3



More information about the notmuch mailing list