[RFC PATCH 3/5] cli: add support for not deduplicating notmuch address results

David Bremner david at tethera.net
Sat Aug 29 18:29:46 PDT 2015


Jani Nikula <jani at nikula.org> writes:


> +	{ NOTMUCH_OPT_KEYWORD, &ctx->dupe, "deduplicate", 'x',

probably you want 'D' or 'd' here. Not that it makes a practical
difference at this point.

> +	  (notmuch_keyword_t []){ { "yes", -1 },

I'm not very enthusiastic about reusing ctx->dupe for this.
In particular the use of -1 for yes is off-putting
It seems better to allocate another word of memory and use an
enum, as elsewhere.


More information about the notmuch mailing list