[PATCH] emacs: tree: mark read change

Tomi Ollila tomi.ollila at iki.fi
Tue Jun 23 14:14:02 PDT 2015


On Tue, Jun 23 2015, David Bremner <david at tethera.net> wrote:

> Mark Walters <markwalters1009 at gmail.com> writes:
>
>> The mark read code for tree mode did not get updated in the recent
>> changes. This updates it to match. Since the user can customize the
>> mark read logic we just call the show logic in the message pane.
>> ---
>>
>> An alternative would be to mark any message explicitly viewed in
>> tree-mode as read. That would be simpler but I think this is better as
>> it deals with user customized mark read functions -- for example if
>> the user has a customized function that only marks a message read if
>> the whole message is viewed then this version will do the same in tree
>> mode.
>
> At first I was leery of the chaining of hooks, but now that I
> noticed/experienced the bug, it makes more sense to me.  I'm considering
> rolling a bug fix release with this (I imagine the bug is pretty
> annoying for people using only notmuch-tree), so I'd like a bit more
> feedback before merging it.

>From code point of view it looks good to me.

Tomi

>
> d


More information about the notmuch mailing list