[PATCH] Re: Add /renew/ tag to moved/renamed/reflagged messages

Gaute Hope eg at gaute.vetsj.com
Sat Apr 11 02:12:11 PDT 2015


Excerpts from David Bremner's message of April 11, 2015 1:56:
> Baptiste <bateast at bat.fr.eu.org> writes:
> 
>> Hi, 
>>
>>> What about another automatic tag to re-add to an existing mail when =notmuch new= detect a moved, renamed or reflagged message ...
>>
>> the following code sample seems to actually do the job …
>>
> 
> Sorry I still haven't had a chance to review your patch in detail. A few
> things I did wonder about
> 
> - There is a patch series in progress to add a "last modified time" to
>   all messages [1]. It seems like this should also work for your case
>   since renaming counts as modification in this context. It might not be
>   quite as easy/efficient for your use case as your proposal, but it
>   seems like it should work.
> 
> - What about messages added by notmuch-insert? I guess you are maybe not
>   using it, but it seems odd to only support changes detected in
>   notmuch-new.
> 
> - This might be because I haven't worked through the details, but it
>   isn't obvious to me how your patch behaves with messages with multiple
>   files on disk.
> 
> 
> 
> [1]: id:1428274754-1698-1-git-send-email-david at tethera.net

I think I sent in something similar [2] before the lastmod stuff, there
are some issues with reliably detecting all changes. Especially, changes
that do not result in a rename. It would be made obsolete by the lastmod
series though.

- gaute

[2]: id:1396800683-9164-1-git-send-email-eg at gaute.vetsj.com 



More information about the notmuch mailing list