[PATCH 1/2] cli: fix top level --help combined with other options

Tomi Ollila tomi.ollila at iki.fi
Tue Mar 10 01:03:44 PDT 2015


On Mon, Mar 09 2015, David Bremner <david at tethera.net> wrote:

> Jani Nikula <jani at nikula.org> writes:
>
>> -	ret = notmuch_help_command (NULL, argc - 1, &argv[1]);
>> +	/*
>> +	 * Pass the first positional argument as argv[1] so the help
>> +	 * command can give help for it. The help command ignores the
>> +	 * argv[0] passed to it.
>> +	 */
>> +	ret = notmuch_help_command (NULL, argc - opt_index + 1,
>> +				    argv + opt_index - 1);
>>  	goto DONE;
>>      }
>
> LGTM

Also to me, too.

Tomi


More information about the notmuch mailing list