[PATCH] Add a defcustom for whether to block remote images by default.

[Tomi Ollila]

On Thu, Jan 29 2015, Jinwoo Lee <jinwoo68 at gmail.com> wrote:

> On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila <tomi.ollila at iki.fi> wrote:
>> On Thu, Jan 29 2015, David Bremner <david at tethera.net> wrote:
>>
>>> Jinwoo Lee <jinwoo68 at gmail.com> writes:
>>>
>>>> +	(shr-blocked-images (if notmuch-show-block-remote-images
>>>> +				"."
>>>> +			      shr-blocked-images)))
>>>>      (shr-insert-document dom)
>>>>      t))
>>>
>>> Ideally such a customization would apply to all html renders. I think
>>> Tomi did some experiments with w3m and friends, I _think_ they respect
>>> gnus-blocked-images, but maybe Tomi can comment.
>>
>> I did M-x debug-on-entry RET open-network-stream RET  (or an equivalent of
>> t that in elisp, but the code I did is now lost & forgotten ;/
>>
>> The docstring relevant to the renderers below it at the end of this email.
>>
>> 'gnus-w3m respect gnus-blocked-images
>>
>> I could not run 'w3m on that system... nor 'w3
>>
>> There was no effect with 'w3m-standalone -- in this case I'd think it is up
>> to w3m binary to load external stuff or not. I presume the same is the
>> case with 'links, 'lynx, 'html2text and nil
>>
>> So, to add to David's suggestion maybe just set both gnus-blocked-images
>> and shr-blocked-images to the value of
>> notmuch-show-text/html-blocked-images
>
> All right.  I sent another patch that does this.  Thanks, guys!

Thanks for your contribution. You seem to have taken my suggestion
literally just that it IIRC now only sets those when using shr renderer --
setting of gnus-blocked images should be in other code path... i am not
sure though i am sending this using mobile phi0one terminal and checking
for sure is just too PITA ;\

Tomi

>
>>
>>
>> Tomi
>>
>>
>> mm-text-html-renderer is a variable defined in `mm-decode.el'.
>> Its value is shr
>>
>> Documentation:
>> Render of HTML contents.
>> It is one of defined renderer types, or a rendering function.
>> The defined renderer types are:
>> `shr': use the built-in Gnus HTML renderer;
>> `gnus-w3m': use Gnus renderer based on w3m;
>> `w3m': use emacs-w3m;
>> `w3m-standalone': use plain w3m;
>> `links': use links;
>> `lynx': use lynx;
>> `w3': use Emacs/W3;
>> `html2text': use html2text;
>> nil    : use external viewer (default web browser).
>>
>>
>>> d
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch