[PATCH v2 1/3] search: Separately report matching and non-matching authors.
David Bremner
david at tethera.net
Sun Jan 18 06:19:23 PST 2015
David Edmondson <dme at dme.org> writes:
> In addition to the 'authors' attribute of each search result, include
> 'authors_matched' and 'authors_non_matched' attributes. Both
> attributes are always included and are formatted as a list of
> authors. If there are no matching authors, the 'authors_non_matched'
> attribute is set to the empty list.
> ---
It would be nicer if the tests were repaired in the same commit, or
minimally marked broken.
> static int
> do_search_threads (sprinter_t *format,
> notmuch_query_t *query,
> @@ -152,6 +253,10 @@ do_search_threads (sprinter_t *format,
> format->integer (format, total);
> format->map_key (format, "authors");
> format->string (format, authors);
> + if (_enumerate_authors (format, thread) < 0) {
> + fprintf (stderr, "Out of memory\n");
> + return 1;
> + }
Maybe I'm just blind, but I don't see how enumerate authors ever returns
anything other than 0.
More information about the notmuch
mailing list