[PATCH v3 10/10] cli: address: Add --filter-by option to configure address filtering

[Michal Sojka]

Hi,

sorry for longer response time :)

On Thu, Jan 01 2015, Tomi Ollila wrote:
> On Wed, Dec 31 2014, David Bremner <david at tethera.net> wrote:
>
>> Michal Sojka <sojkam1 at fel.cvut.cz> writes:
>>
>>> This option allows to configure the criterion for duplicate address
>>> filtering. Without this option, all unique combinations of name and
>>> address parts are printed. This option allows to filter the output
>>> more, for example to only contain unique address parts.
>>
>> I had the feeling there was some "controversy" about the UI here, but
>> following back the 3 versions of the series I didn't see it. Does that
>> mean we just need to sanity check the code, or are there outstanding
>> bikes to shed?

I'd tend to rename this option to --unique as it was in some previous
version of the patch. Another thing in my mind is the implementation of
the --complete option mentioned in id:878uid9qjl.fsf at nautilus.nautilus.
This would also involve some kind of address filtering. I'll look into
this and send patches later.

> I have intentionally been guiet on this during the review process of the
> other patches to not slow down the acceptance of the others. I have not
> got enough time to look the implemenentation or think this last patch
> further -- from the user interface point of view I recall seeing there
> both useless features (but which might be warranted by implementation
> simplicity) and missing features (but which might not be there due to 
> difficulty in implementation). Also, I am not sure whether the --filter-by
> is good option (and options descriptive...)...

I'd be interested in what are these "missing features".

Cheers,
-Michal