[PATCH] test: Make gen-threads work with python3
Jesse Rosenthal
jrosenthal at jhu.edu
Fri Oct 31 11:04:50 PDT 2014
"W. Trevor King" <wking at tremily.us> writes:
> On Fri, Oct 31, 2014 at 01:33:25PM -0400, Jesse Rosenthal wrote:
>> We instead initalize the dictionary using the dict comprehension and
>> then update it with the values from the tree. This will work with
>> both python2 and python3.
>
> Dict comprehensions are new in 2.7 [1,2], so this drops support for
> systems where ‘python’ means ‘python2.6’. Personally, I'm fine with
> that, but I thought I'd point it out in case 2.6 users wanted to push
> back ;).
The comprehension was already in the previous version, so I figured that
people were already cool with 2.7+.
>> -
>> import sys
>
> Why remove this blank line?
Oops -- I had put in a print_function import from __future__ for
testing. Must have lost the line when I took it back out. Is it worth
resubmitting to fix that?
More information about the notmuch
mailing list