[PATCH] test: fix test_require_external_prereq gdb in insert test
David Bremner
david at tethera.net
Tue Oct 28 13:56:46 PDT 2014
Jani Nikula <jani at nikula.org> writes:
>> Of course you're right that moving it forward to only skip the gdb
>> requiring tests is the right thing to do, and in that setting having a
>> skipped message for all 10 skipped tests is a bit ugly. OTOHO your
>> version doesn't give any output at all, which seems not perfect either.
>
> How does it work if you just move the prereq test forward?
>
Then we get one message per skipped test. So twenty lines it total.
missing prerequisites: gdb(1)
SKIP error exit when add_message returns OUT_OF_MEMORY
missing prerequisites: gdb(1)
SKIP success exit with --keep when add_message returns OUT_OF_MEMORY
missing prerequisites: gdb(1)
SKIP error exit when add_message returns XAPIAN_EXCEPTION
missing prerequisites: gdb(1)
SKIP success exit with --keep when add_message returns XAPIAN_EXCEPTION
missing prerequisites: gdb(1)
SKIP error exit when add_message returns FILE_NOT_EMAIL
missing prerequisites: gdb(1)
SKIP success exit with --keep when add_message returns FILE_NOT_EMAIL
missing prerequisites: gdb(1)
SKIP error exit when add_message returns READ_ONLY_DATABASE
missing prerequisites: gdb(1)
SKIP success exit with --keep when add_message returns READ_ONLY_DATABASE
missing prerequisites: gdb(1)
SKIP error exit when add_message returns UPGRADE_REQUIRED
missing prerequisites: gdb(1)
SKIP success exit with --keep when add_message returns UPGRADE_REQUIRED
More information about the notmuch
mailing list