[PATCH] test: fix test_require_external_prereq gdb in insert test
David Bremner
david at tethera.net
Tue Oct 28 11:15:50 PDT 2014
Jani Nikula <jani at nikula.org> writes:
> You need to actually check the return value. Limit the missing deps
> part to subtests requiring gdb.
For me, on a system without gdb, the current version looks like
T070-insert: Testing "notmuch insert"
missing prerequisites: gdb(1)
SKIP all tests in T070-insert
This seems OK to me?
Of course you're right that moving it forward to only skip the gdb
requiring tests is the right thing to do, and in that setting having a
skipped message for all 10 skipped tests is a bit ugly. OTOHO your
version doesn't give any output at all, which seems not perfect either.
More information about the notmuch
mailing list