[PATCH v3] VIM: Add URI handling

Ian Main imain at stemwinder.org
Fri Oct 24 10:03:52 PDT 2014


Tomi Ollila wrote:
> On Fri, Oct 24 2014, Ian Main <imain at stemwinder.org> wrote:
> 
> This patch does not apply on top of notmuchmail master 
> (commit 38240d106139da8).
> 
> > This patch adds URI handling to the vim client.  You can now press
> 
> Although insignificant, I'll start commenting on all sent patches
> (that I look into) which talk like 'This patch adds' -- sure it is patch
> when email is sent, but in repository it is not so -- so the commit message
> should not mention it (but I do not require changing it).
> 
> Anyway, I suspect this change will become applicable after some other
> change is committed first -- and IMO this could stay as non-stale patch
> provided that SomeOne(TM) informs what is the message that contains
> changes (or series those) that is required for this message to apply.
> 
> BTW: does the content of this change differ much from v1 at
> id:1412281423-22441-1-git-send-email-imain at stemwinder.org
> or should I re-check (carefully!) that the changes are still OK.
> 
> 
> Tomi
> 

This one is almost identical minus the hotkey usage.  The attachment support
patch has changed a fair bit in that it now looks at all parts of multipart
messages, giving you the opportunity to view the original text/html message
in a web browser.

I sent them out as a series in a new thread so that it would be easier to
follow.  I have them all applied locally and there were some conflicts to
resolve.  They are simple, usually around the defaults settings for the
configuration but it's still a pain.  I'm still tempted to send out all
of the outstanding patches as a big series.  All the patches posted though
should apply to master so I may just have to rebase now and again.

    Ian


More information about the notmuch mailing list