[PATCH 08/11] lib: Implement upgrade to ghost messages feature

David Bremner david at tethera.net
Sun Oct 5 23:03:06 PDT 2014


Austin Clements <aclements at csail.mit.edu> writes:

> Quoth David Bremner on Oct 05 at 10:56 am:
>> Austin Clements <aclements at csail.mit.edu> writes:
>> > +    if (new_features & NOTMUCH_FEATURE_GHOSTS) {
>> > +	t_end = db->metadata_keys_end ("thread_id_");
>> > +	for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t)
>> > +	    ++total;
>> > +    }
>> 
>> It would be nice to have the comment below, or something like it, for
>> the loop above.
>
>   /* The ghost message upgrade converts all thread_id_*
>    * metadata values into ghost message documents. */
> sound good?

Fine.

d


More information about the notmuch mailing list