[PATCH 09/11] cli/insert: add fail path to add_file_to_database

[David Bremner]

Jani Nikula <jani at nikula.org> writes:


> +	status = notmuch_message_tags_to_maildir_flags (message);

...

> +	/*
> +	 * Note: Unfortunately a failed maildir flag sync might
> +	 * already have renamed the file, in which case the cleanup
> +	 * path will fail.
> +	 */

I'd like to be more explicit about what potentially bad outcomes there
are here.  I guess this message file gets left on disk, unindexed,
perhaps forever if the user never runs notmuch new? Would it make sense
to suggest the user run notmuch new to "recover" these message files?