[PATCH 0/2] Improve message threading

Tomi Ollila tomi.ollila at iki.fi
Sun Aug 10 12:49:45 PDT 2014


On Mon, May 26 2014, Michal Sojka <sojkam1 at fel.cvut.cz> wrote:

> Hi all,
>
> I noticed that in certain situations notmuch does not reconstruct
> thread structure correctly. The fix was quite trivial - see the
> patches.
>
> The patch fixes my problem, however, as I learnt from the thread
> around id:87oazwjq1e.fsf at yoom.home.cworth.org, there are more problems
> in this code. I think that my problem is orthogonal to what was
> discussed there.
>
> The patch does not break any existing text (except two in
> T460-emacs-tree.sh, which fail even with 0.18 on my system).
>
> Cheers,
> -Michal

This series looks good to me, and patch 2/2 fixes the borken test
introduced in patch 1/2 -- i.e. the fix is clear, test is somewhat
tedious to be parsed by a human ;D

Tomi


>
> Michal Sojka (2):
>   Add test for incorrect threading of messages
>   Make parsing of References and In-Reply-To header less error prone
>
>  lib/database.cc             | 15 ++++++---------
>  test/T510-thread-replies.sh | 27 +++++++++++++++++++++++++++
>  2 files changed, 33 insertions(+), 9 deletions(-)
>
> -- 
> 2.0.0.rc2
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


More information about the notmuch mailing list