[PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

Karl Fogel kfogel at red-bean.com
Mon Jul 7 10:35:54 PDT 2014


Sebastian Lipp <bacuh at riseup.net> writes:
>Karl Fogel <kfogel at red-bean.com>
>> In general, supplying a log message with the patch with avoid such
>> confusion.  If there is some prose expressing what the change is
>> supposed to to, and giving any historical context (such as the mailing
>> list thread starting from last year), then it will be easy for any
>> reviewer to understand what the patch is intended to do, and check if it
>> actually does that.
>
>Okay, next time I will provide that information inline. Thought keeping
>References and In-Reply-To headers would be sufficient reference.

Well, when the patch is committed into a version control system, it's
going to need a log message (commit message) anyway.  Since that message
is considered part of the change -- anyone reading the change will start
by reading the commit message -- it's typical to just include it with
the diff.

The commit message can certainly include a reference to the email
thread; in fact, it's good if it does so.

Best,
­Karl


More information about the notmuch mailing list