[PATCH v2 01/10] lib: add return status to database close and destroy

[David Bremner]

Peter Wang <novalazy at gmail.com> writes:

> From: Jani Nikula <jani at nikula.org>
>
> notmuch_database_close may fail in Xapian ->flush() or ->close(), so
> report the status. Similarly for notmuch_database_destroy which calls
> close.

This patch looks OK, and it makes sense independent of what else
follows with respect to notmuch-insert.

With respect so SONAME bumping, we might be able to get away with out it
here (although that could be un-portable or broken in a way I haven't
seen yet), but we can also delay that decision until closer to the next
release; I don't think it's as important to provide a stable ABI for
people building from git, and I'd prefer to batch ABI changes into one
SONAME bump.