[PATCH v3 5/9] emacs/show: Remove the 'no-buttons option of `notmuch-show-insert-bodypart'

[Mark Walters]

On Mon, 12 May 2014, David Edmondson <dme at dme.org> wrote:
> No code uses the 'no-buttons argument to
> `notmuch-show-insert-bodypart', so remove it.
> ---
>  emacs/notmuch-show.el | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index e511655..981b922 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -915,9 +915,7 @@ message at DEPTH in the current thread."
>  
>  HIDE determines whether to show or hide the part and the button
>  as follows: If HIDE is nil, show the part and the button. If HIDE
> -is t, hide the part initially and show the button. If HIDE is
> -'no-buttons, show the part but do not add any buttons (this is
> -useful for quoting in replies)."
> +is t, hide the part initially and show the button."
>  
>    (let* ((content-type (downcase (plist-get part :content-type)))
>  	 (mime-type (notmuch-show-mime-type part))
> @@ -926,9 +924,8 @@ useful for quoting in replies)."
>  	 ;; Hide the part initially if HIDE is t.
>  	 (show-part (not (equal hide t)))

Just a triviality: we might as well make the above (not hide) now.

MW

>  	 ;; We omit the part button for the first (or only) part if
> -	 ;; this is text/plain, or HIDE is 'no-buttons.
> -	 (button (when (and (not (equal hide 'no-buttons))
> -			    (funcall notmuch-show-insert-header-p-function part))
> +	 ;; this is text/plain.
> +	 (button (when (funcall notmuch-show-insert-header-p-function part)
>  		   (notmuch-show-insert-part-header nth mime-type content-type (plist-get part :filename))))
>  	 (content-beg (point)))
>  
> -- 
> 2.0.0.rc0
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch