[PATCH 0/5] nmbug-status fixups from notmuch-to-html

Tomi Ollila tomi.ollila at iki.fi
Sat May 10 14:08:10 PDT 2014


On Sat, May 10 2014, "W. Trevor King" <wking at tremily.us> wrote:

> I've cherry-picked the three patches I liked from Carl's master [1,2]
> and added two cleanup commits of my own.  I've left Carl's commit
> messages unchanged.  I'm fine squashing my fixups into Carl's
> originals (leaving Carl as the author) if that's ok with him.

I think the series is good as it is.

I like seeing something after last patch at the end of the page -- It makes
it easier to notice when patches end. Perhaps I  get used to see date
there.

The rendered <hr/> irritates me a bit, though. Maybe it could be colored
light gray ?

> Cheers,
> Trevor

Tomi


>
> [1]: id:20140423001824.GM9243 at odin.tremily.us
>      http://thread.gmane.org/gmane.mail.notmuch.general/17986/focus=17994
> [2]: git://git.cworth.org/git/notmuch-to-html
>
> Carl Worth (3):
>   Add explicit license information
>   Move the generated date from the top of the page to the footer.
>   Add a comment describing the program
>
> W. Trevor King (2):
>   nmbug-status: Use a triple-quoted string for the footer template
>   nmbug-status: Shift the script description into a docstring
>
>  devel/nmbug/nmbug-status | 36 +++++++++++++++++++++++++++++-------
>  1 file changed, 29 insertions(+), 7 deletions(-)
>
> -- 
> 1.9.1.353.gc66d89d


More information about the notmuch mailing list