[PATCH] doc: Fix parallel build of roff files

W. Trevor King wking at tremily.us
Sat May 10 08:18:33 PDT 2014


On Thu, Apr 17, 2014 at 04:34:57PM -0400, Austin Clements wrote:
> +$(DOCBUILDDIR)/.roff.stamp: ${MAN_RST_FILES}
>  ifeq ($(HAVE_SPHINX),1)
>  	$(SPHINXBUILD) -b man $(ALLSPHINXOPTS) $(DOCBUILDDIR)/man
>  	for section in 1 5 7; do \
> @@ -48,6 +54,7 @@ else
>  	@echo "Fatal: build dependency fail."
>  	@false
>  endif
> +	touch ${MAN_ROFF_FILES} $@

I'm poking around in the Makefile, and don't understand why we're
touching ${MAN_ROFF_FILES} here.  Either they were just created by
Sphinx/rst2man, or we died with the @false.  I doubt Sphinx or
prerst2man.py are intelligent enough to not clobber the roff files if
their content hasn't changed, but I don't see a point in explicitly
bumping timestamps either.

I think I'll drop the ${MAN_ROFF_FILES} as part of the patch I'm
working on, but let me know if I'm just missing something.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140510/0e1cbab8/attachment.pgp>


More information about the notmuch mailing list