[PATCH v4 0/2] emacs: show: redesign unread/read logic

Mark Walters markwalters1009 at gmail.com
Thu May 8 17:20:06 PDT 2014


This is v4 of this set. v3 is at id:1395777793-13297-1-git-send-email-markwalters1009 at gmail.com

David (dme) was not keen on the logic in the previous patch so I have
tried to make it rather more customisable and made this version much
closer to the existing logic.

This version marks the current message read if it is open. It doesn't
care how you get there: whether it is notmuch commands n/N/p/P next
message etc, emacs commands like scroll up, mouse clicks etc.

The only proviso is it will only mark a message read once (in a single
buffer and between refreshes) as otherwise it is impossible for a user
to choose to mark a message unread.

I, personally, like my previous logic much more. But with this setup
that can be customized easily in my .emacs (we may choose to add other
options into mainline later). Also I think this series fixes all of
the problems with the current read/unread logic mentioned in
id:87a9atmpkf.fsf at qmul.ac.uk are fixed.

The first patch is unchanged. Since the new mark-read function is
small it folded neatly into the patch removing the old unread logic.

Finally, as with previous versions, all tests pass.

Best wishes

Mark




Mark Walters (2):
  test: make test_emacs call post-command-hook
  emacs: show: add an update seen function to post-command-hook

 emacs/notmuch-show.el |   43 ++++++++++++++++++++++++++++---------------
 test/test-lib.el      |   11 +++++++++++
 test/test-lib.sh      |    2 +-
 3 files changed, 40 insertions(+), 16 deletions(-)

-- 
1.7.10.4



More information about the notmuch mailing list