[PATCH 1/2] emacs: hello: bugfix: make alphabetically sorted saved searches work

Jani Nikula jani at nikula.org
Sat Apr 12 03:50:02 PDT 2014


On Sat, 12 Apr 2014, Mark Walters <markwalters1009 at gmail.com> wrote:
> My recent changes to the saved search format broke the alphabetically
> sorted saved sort option. This makes it work again.
>
> Also, since the saved-search list is no longer an alist change the
> names in the sort function to avoid confusion.
> ---
> Thanks to Jani for pointing out the bug.

Looks good, works for me, thanks for the fix.

BR,
Jani.

>
> Best wishes
>
> Mark
>
>  emacs/notmuch-hello.el |    9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 4900a24..fca2bcc 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -39,9 +39,12 @@ (defcustom notmuch-show-empty-saved-searches nil
>    :type 'boolean
>    :group 'notmuch-hello)
>  
> -(defun notmuch-sort-saved-searches (alist)
> -  "Generate an alphabetically sorted saved searches alist."
> -  (sort (copy-sequence alist) (lambda (a b) (string< (car a) (car b)))))
> +(defun notmuch-sort-saved-searches (saved-searches)
> +  "Generate an alphabetically sorted saved searches list."
> +  (sort (copy-sequence saved-searches)
> +	(lambda (a b)
> +	  (string< (notmuch-saved-search-get a :name)
> +		   (notmuch-saved-search-get b :name)))))
>  
>  (defcustom notmuch-saved-search-sort-function nil
>    "Function used to sort the saved searches for the notmuch-hello view.
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


More information about the notmuch mailing list