[Patch v5 3/6] util: add gz_readline

Kim Minh Kaplan kimminh.kaplan+nomuch at afnic.fr
Wed Apr 2 23:17:44 PDT 2014


Tomi Ollila writes:

> On Wed, Apr 02 2014, Austin Clements <amdragon at MIT.EDU> wrote:
>
>> Quoth David Bremner on Apr 01 at 10:16 pm:
>>
>>> +    if (len == 0 || buf == NULL) {
>>> +	/* same as getdelim from gnulib */
>>> +	len = 120;
>>
>> This is presumably because glibc's malloc has an 8 byte header.  Fun
>> fact: talloc has a 104 byte header (on 64-bit and including the malloc
>> header).
>
> hmm, what should we choose here? 152 ? Some bikeshedding on IRC ?

When your done with this bikeshed, do not forget the other one :

>>> +	len *= 2;

-- 
Kim Minh.


More information about the notmuch mailing list