[PATCH 15/17] nmbug-status: Quote the title when using it as an id

Tomi Ollila tomi.ollila at iki.fi
Sun Feb 9 01:34:39 PST 2014


On Sun, Feb 09 2014, "W. Trevor King" <wking at tremily.us> wrote:

> On Mon, Feb 03, 2014 at 02:59:33AM -0800, W. Trevor King wrote:
>> +            if 'id' not in view:
>> +                view['id'] = quote(view['title'])
>
> Stuff like href="#Maybe%20Ready%20%28Core%20and%20Emacs%29" wasn't
> working for me on Firefox 24.2.0, so I've tweaked this commit to slug
> titles instead of quoting them.  Pushed to my nmbug-status-python3
> branch and queued for my v2 submission.

$ git checkout nmbug-status-python3
$ git pull --rebase
$ ./devel/nmbug/nmbug-status

Looks pretty good to me. I am not sure whether the commit messages should
be *that* verbose, though...

>
> Cheers,
> Trevor

Tomi


More information about the notmuch mailing list