[PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons

Tomi Ollila tomi.ollila at iki.fi
Tue Feb 4 02:31:36 PST 2014


On Tue, Feb 04 2014, "W. Trevor King" <wking at tremily.us> wrote:

> On Mon, Feb 03, 2014 at 10:44:39PM +0200, Tomi Ollila wrote:
>> having notmuch patch email as expected test output feels a bit
>> confusing to me -- especially as 'git grep' may catch some of the
>> (possibly future-outdated) content...
>
> There were two very similar patches with filename attachments in the
> corpus, so I used them for the tests ;).  I can convert that test to
> use emacs_fcc_message or some other auto-generated content if you'd
> prefer.

You're right; corpus seems to be full of notmuch patch emails...


... and (although?) (just noticed)...

$ grep '^ *[+-].*\<if\>' test/* test/*/*
test/emacs.expected-output/attachment:+    if (pw_buf_size == -1)
pw_buf_size = 64;
test/emacs.expected-output/attachment:+    if (pw_buf_size == -1)
pw_buf_size = 64;

... I am not giving much resistance to keep the patch as it is :D

>
> Cheers,
> Trevor
>

Tomi


More information about the notmuch mailing list