[PATCH 0/2]
W. Trevor King
wking at tremily.us
Mon Feb 3 02:45:32 PST 2014
On Mon, Feb 03, 2014 at 08:04:21AM +0000, Mark Walters wrote:
> I think notmuch-show.c gets most of the header and related
> information directly from the mail file not from the database
> directly. I think we use gmime for that parsing so adding an extra
> output pair for content-description there should be
> sufficient. (This is lines 655-700 or so notmuch-show.c)
Thanks, that's exactly what I needed :).
> I think the emacs side should be roughly as above: we would need to
> check that the default filename offered when saving is still
> correct.
notmuch-save-attachments is using:
(assq 'filename disposition)
and it looks like 'name' in notmuch-show-insert-part-header is only
used for the button text.
> Stylistically I think
> + (name (or (plist-get part :content-description)
> + (plist-get part :filename)))
>
> is a little nicer.
Thanks for clearing up my search-engine Lisp ;). Fixed in these
patches.
Cheers,
Trevor
p.s. I checked a few earlier patches on the list and didn't see
reviewer CCs. On the other hand, I didn't see any Reply-To headers
either, so I'm CCing my reviewers to be safe ;). Let me know if the
convention is to not CC reviewers, and I'll restrict future
submissions to notmuch at .
W. Trevor King (2):
notmuch-show: Add content-description output pair
emacs: Prefer Content-Description over filename for part buttons
NEWS | 9 +++
emacs/notmuch-show.el | 4 +-
notmuch-show.c | 8 +++
test/T160-json.sh | 4 +-
test/T170-sexp.sh | 4 +-
test/T450-emacs-show.sh | 12 ++++
test/corpus/cur/24:2, | 1 +
.../notmuch-show-buttons-content-description | 84 ++++++++++++++++++++++
.../notmuch-show-buttons-filename | 74 +++++++++++++++++++
9 files changed, 195 insertions(+), 5 deletions(-)
create mode 100644 test/emacs-show.expected-output/notmuch-show-buttons-content-description
create mode 100644 test/emacs-show.expected-output/notmuch-show-buttons-filename
--
1.8.5.2.8.g0f6c0d1
More information about the notmuch
mailing list