[PATCH] configure: only install bash completion if supported

David Bremner david at tethera.net
Sun Feb 2 15:18:31 PST 2014


Jani Nikula <jani at nikula.org> writes:

> On Sun, 02 Feb 2014, David Bremner <david at tethera.net> wrote:
>> Mark Walters <markwalters1009 at gmail.com> writes:
>>
>>> This LGTM (untested)
>>
>> I did test it, at least completely removing bash completion works as
>> expected.  
>>
>> Unfortunately --with-bash-completion does not override this test because
>> the order things are processed. Do you think this is a bug?  I wondered
>> if users that "know what they are doing" (TM) might want to force
>> installation even though the pkg-config test fails.
>
> I thought it was a feature, not a bug, but I'm fine either way.

I can live with the current patch. As you pointed out on IRC, this is
the usual way missing dependencies work.  And I think we should avoid
extra complications in the configure script when we can.


More information about the notmuch mailing list