[PATCH] configure: only install bash completion if supported
Mark Walters
markwalters1009 at gmail.com
Sun Feb 2 09:40:38 PST 2014
This LGTM (untested)
I think this is the right way to do this: I don't think we should
spam a user with error messages for attempting tab completion with
an older version of bash-completion (which I think you said was the case
with the other version)
Best wishes
Mark
On Sun, 02 Feb 2014, Jani Nikula <jani at nikula.org> wrote:
> Our bash completion depends on bash-completion 1.90 or later. Only
> install where available.
> ---
> configure | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/configure b/configure
> index 13b6062..66aaedb 100755
> --- a/configure
> +++ b/configure
> @@ -360,6 +360,14 @@ else
> have_valgrind=0
> fi
>
> +printf "Checking for bash-completion (>= 1.90)... "
> +if pkg-config --atleast-version=1.90 bash-completion; then
> + printf "Yes.\n"
> +else
> + printf "No (will not install bash completion).\n"
> + WITH_BASH=0
> +fi
> +
> if [ -z "${EMACSLISPDIR}" ]; then
> if pkg-config --exists emacs; then
> EMACSLISPDIR=$(pkg-config emacs --variable sitepkglispdir)
> --
> 1.8.5.2
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
More information about the notmuch
mailing list