[PATCH 1/1] emacs: ad-activate 'mm-shr after ad-disable-advice 'mm-shr

[Austin Clements]

On Mon, 27 Jan 2014, Tomi Ollila <tomi.ollila at iki.fi> wrote:
> Imitated from "Enabling advice" in Emacs lisp manual...
>
> ad-disable-advice by itself only changes the enable flag for a
> piece of advice. To make the change take effect in the
> advised definition, the advice needs to be activated again.

Oops, looks like this was my fault.

This fix LGTM.

> ---
>  emacs/notmuch-lib.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index e6e9f97..fa35fa9 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -531,7 +531,8 @@ the given type."
>  (if (>= emacs-major-version 24)
>      (defadvice mm-shr (before load-gnus-arts activate)
>        (require 'gnus-art nil t)
> -      (ad-disable-advice 'mm-shr 'before 'load-gnus-arts)))
> +      (ad-disable-advice 'mm-shr 'before 'load-gnus-arts)
> +      (ad-activate 'mm-shr)))
>  
>  (defun notmuch-mm-display-part-inline (msg part nth content-type process-crypto)
>    "Use the mm-decode/mm-view functions to display a part in the
> -- 
> 1.8.0
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch