[PATCH 3/4] test: sanitize dates in emacs, raw, and text output

David Bremner david at tethera.net
Sun Dec 8 17:17:41 PST 2013


Austin Clements <amdragon at MIT.EDU> writes:

> This may be orthogonal to this series, but I don't get why we have
> both notmuch_show_sanitize and notmuch_show_sanitize_all (especially
> when the "all" version is not obviously a superset of the non-"all"
> version!)  Do you have a sense for whether these two functions could
> be easily merged?

Yeah, I don't really understand the reason for these two functions
either. I also discovered (and deleted) another duplicate file name
sanitization function elsewhere in the series, so it wouldn't surprise
me if it's just collective sloppiness.

>
> Rather than (nearly) duplicating the regexp, does it work to pipe this
> through notmuch_date_sanitize?  Or do the minor differences matter?
>

I'll try this out.

d


More information about the notmuch mailing list