[PATCH v2 5/5] compact: provide user more information on after-compaction failures

[David Bremner]

Tomi Ollila <tomi.ollila at iki.fi> writes:

> The log hook in it's current form is problematic as it doesn't provide
> way to distinguish progress reporting from error reporting.

Is this _more_ problematic than more output to stderr?

>  Currently
> lib/database.cc writes error messages with fprintf(stderr, ...) everywhere.

Sure. But I'm trying to understand why a partial fix isn't better than
nothing.  Is the argument just that the effort is wasted, or that the
result is somehow less satisfactory than the status quo.

> I suggest that this problem is fixed in one big sweep during 0.18
> development -- the suggestion Jani pastebin'd a few days ago is
> a good one and I'm willing to take part of that development...
> And now take this approach of fprintf()ing (basically I would
> also ask developers using the library wait for 0.18 before starting
> to use the compact functionality (if ever), as the we have yet
> another soname bump with changing interface coming...

I guess we can mark this interface as unstable for the moment?
"Asking developers not to use it" sounds pretty bad.

d