[PATCH v2 5/5] compact: provide user more information on after-compaction failures

[David Bremner]

Jani Nikula <jani at nikula.org> writes:

> On Wed, 13 Nov 2013, Tomi Ollila <tomi.ollila at iki.fi> wrote:
>> After database has been compacted, there are steps to put the new
>> database into place -- and these steps may fail. In case such
>> failure happens, provide better information how to resolve it.
>
> I disagree with having a library spew all this information out. For each
> case, I think it should be sufficient to just say what happened
> (e.g. "rename a -> b failed" + strerror). I don't think a library's
> error messages should be a tutorial on how to fix things.
>

I can live with whatever the concensus level of verbosity, but not the
fprintf's; as I mentioned, for once we have a log hook.

That might also somewhat comfort Jani, since the library client has the
option of ignoring the spewing.

d