[PATCH v2 00/11] compactor changes v2

[Tomi Ollila]

On Tue, Nov 05 2013, David Bremner <david at tethera.net> wrote:

> Jani Nikula <jani at nikula.org> writes:
>
>> Hi all, this is v2 of [1], incorporating compact related patches from
>> David, some changes from David's review, some new patches, man page
>> update, test update.
>>
>> Cheers,
>> Jani.
>
> Aside from the one quibble that I already sent seperately, the first 8
> patches look OK to me. I have no technical objections to the last 3, but
> since the change the UI, I'd like to wait a bit for more input from
> other people.


The whole series looks OK to me. The only thing I'm, a bit worried about
what happens is I Ctrl-C compaction at any state. Is it possible that I
end up with corrupted database ? Someone may accidentally execute
notmuch compact -- for example by picking the command from history.

If it is possible what is the likelihood that happening (also comparing
w/ notmuch tag, notmuch new & notmuch insert managing to corrupt database)

I personally would like to be sure. OTOH if others don't see issue
there (perhaps with a good reason) I'm fine with the patches as those
are now.


Tomi