[PATCH 4/4] database: Handle error while deleting uncompacted database

Ben Gamari bgamari.foss at gmail.com
Mon Nov 4 12:06:07 PST 2013


David Bremner <david at tethera.net> writes:

> Ben Gamari <bgamari.foss at gmail.com> writes:
>
>> We never checked to ensure that the rmtree() of the old database
>> succeeded.
>>
>
> Is there some reason these patches (and the existing compact code in the
> lib) is using fprintf and not the status callback function? Most places
> we don't (yet) have logging callbacks, but here we do.
>
Nope. I simply wasn't aware of this infrastructure. I can put together a
patch to fix this.

Cheers,

- Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20131104/eca30aa1/attachment.pgp>


More information about the notmuch mailing list