[PATCH] test: fix compact backup / restore test
David Bremner
david at tethera.net
Sat Nov 2 07:56:58 PDT 2013
Tomi Ollila <tomi.ollila at iki.fi> writes:
> On Sat, Nov 02 2013, David Bremner <david at tethera.net> wrote:
>
>> It was looking in completely the wrong place for the backup and the
>> (test) xapian database. Unfortunately test_begin_subtest hides the
>> relevant errors.
>> ---
>
> LGTM. It took me a while noticing that also ${TEST_TMPDIR}
> was changed to ${MAIL_DIR}
Globally it makes me a bit nervous to be doing destructive operations on
${MAIL_DIR}, but that isn't specific to this patch. I wonder if it would
be worth globally replacing the variable with something like
TEST_MAIL_DIR just to make collision with user environment less
likely. Or maybe it's enough just to be careful to override MAIL_DIR.
d
More information about the notmuch
mailing list