[PATCH 0/3] General fixes

Tomi Ollila tomi.ollila at iki.fi
Sat Nov 2 06:39:28 PDT 2013


On Sat, Nov 02 2013, Felipe Contreras <felipe.contreras at gmail.com> wrote:

> David Bremner wrote:
>> Felipe Contreras <felipe.contreras at gmail.com> writes:
>> 
>> > David Bremner wrote:
>> >> Felipe Contreras <felipe.contreras at gmail.com> writes:
>> >> 
>> >> > Felipe Contreras (3):
>> >> >   query: bind queries to database objects
>> >> >   ruby: allow build with RUNPATH
>> >> >   ruby: bind database close()/destroy() properly
>> >> 
>> >> I agree with the discussion on IRC that the change in the first patch
>> >> makes sense.
>> >
>> > Shall I push it to the master branch then?
>> 
>> sure.
>
> Done.
>
>> > I don't really care that much about patch #2, but #3 should probably be
>> > applied.
>> 
>> Just to be clear, I wasn't objecting to patch 2, just asking for a few
>> more words of commit message.
>
> Yes, that's what I understood, but at the moment I don't thin it's worth my
> time to do that. There's mor interesting stuff to do, maybe later.

Lame excuse >;)

>
>> For patch 3, since it's ruby specific and
>> nobody complained, I'd say go for it.
>
> All right. I'll probably wait a bit more, maybe a week to see if somebody
> shouts.

Remember Feature freeze: November 8

>
> -- 
> Felipe Contreras

Tomi


More information about the notmuch mailing list