[PATCH 1/3] cli: add insert --must-index option

David Bremner david at tethera.net
Thu Oct 10 03:41:07 PDT 2013


Peter Wang <novalazy at gmail.com> writes:

> On Tue, 10 Sep 2013 09:06:00 +0100, Mark Walters <markwalters1009 at gmail.com> wrote:
>> 
>> Alternatively maybe add notmuch_database_destroy_with_flush or something
>> which does give a return value. notmuch_database_close is only called 3
>> times and notmuch_database_destroy lots of times so changing close is
>> much less intrusive than changing destroy. But I don't know whether we
>> would break any  bindings or external programs etc.
>> 
>> What do you think?
>
> I think notmuch_database_close and notmuch_database_destroy should
> return the status, and we update the three language bindings
> and bump the soname.
>

I'm not opposed to doing an SONAME bump for 0.17. Are there other ABI
breaking changes that we have been holding back on? Can these maybe go
through at the same time?

d


More information about the notmuch mailing list