[PATCH 1/1] notmuch-mutt: Fix tagging issues

Kevin J. McCarthy kevin at 8t8.us
Sat Sep 7 08:57:48 PDT 2013


Tomi Ollila wrote:
> The patch looks good to me, just that I cannot test it. +1.
> 
> If it weren't inconsistent what is there now a simpler alternative could be:
> 
> system qw/notmuch tag/, @_, '--', "id:$mid";
> 
> or even
> 
> exec qw/notmuch tag/, @_, '--', "id:$mid";
> 
> ... as these bypasses the intermediate shell altogether.

Thank you for the great suggestion.  I completely forgot about the list
form of system while focusing on the patch :-).  Since we don't need the
shell in this case, it makes sense to use that form.

Please hold off on committing this patch.  I will post a revised patch.

-Kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20130907/797d90e4/attachment-0001.pgp>


More information about the notmuch mailing list