[Patch v2 0/3] contrib: pick: remove an unused variable

Tomi Ollila tomi.ollila at iki.fi
Mon Sep 2 08:17:18 PDT 2013


On Tue, Aug 27 2013, Mark Walters <markwalters1009 at gmail.com> wrote:

> v2 of this series is at
> id:1377460214-4795-1-git-send-email-markwalters1009 at gmail.com
>
> v2 had a bug on refresh view (which I should have tested more). The
> main pick view only worked by fluke as the initial call to pick-worker
> was inside a let binding.
>
> This version fixes the bug, moves the call to pick-worker outside the
> let binding (so the bug would have shown up sooner) and also adds a
> test for refresh view.
>
> It is also rebased on top of
> id:1377547043-17584-1-git-send-email-markwalters1009 at gmail.com so that
> series should be applied first.

Looks Good, tests pass. +1

>
> Best wishes
>
> Mark

Tomi


>
>
> Mark Walters (3):
>   contrib: pick: remove unneeded variable notmuch-pick-buffer-name
>   contrib: pick: add docstring for notmuch-pick-worker
>   contrib: pick: test: refresh view
>
>  contrib/notmuch-pick/notmuch-pick.el |   29 +++++++++++++----------------
>  contrib/notmuch-pick/test/emacs-pick |   11 +++++++++++
>  2 files changed, 24 insertions(+), 16 deletions(-)
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
>

-- 
uussigu


More information about the notmuch mailing list