[PATCH 3/6] reply: Document the reason for g_mime_filter_headers

Austin Clements amdragon at MIT.EDU
Mon Aug 12 11:40:36 PDT 2013


Given how long it took me to figure out why we pass the reply headers
through g_mime_filter_headers, it's worth a comment.
---
 notmuch-reply.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/notmuch-reply.c b/notmuch-reply.c
index e151f78..3b2b58d 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -34,6 +34,10 @@ show_reply_headers (GMimeMessage *message)
 	g_mime_stream_file_set_owner (GMIME_STREAM_FILE (stream_stdout), FALSE);
 	stream_filter = g_mime_stream_filter_new(stream_stdout);
 	if (stream_filter) {
+		// g_mime_object_write_to_stream will produce
+		// RFC2047-encoded headers, but we want to present the
+		// user with decoded headers and let whatever
+		// ultimately sends the mail do the RFC2047 encoding.
 		g_mime_stream_filter_add(GMIME_STREAM_FILTER(stream_filter),
 					 g_mime_filter_headers_new());
 		g_mime_object_write_to_stream(GMIME_OBJECT(message), stream_filter);
-- 
1.7.10.4



More information about the notmuch mailing list