[PATCH] contrib: pick: use notmuch-start-notmuch
Mark Walters
markwalters1009 at gmail.com
Thu Jul 4 00:09:48 PDT 2013
This uses the new notmuch-start-notmuch function which should give
better handling of stderr and errors generally.
---
Hi
This converts pick to Austin's new async error handling code (see
commit 08fde50bf3a4c54f6413aff4052e0d84392463f9). That code separates
stderr from stdout and makes sure that appropriate messages are
displayed to the user.
I think this is simple enough and beneficial enough to go in for 0.16
(so I will tag it 0.16). Of course it only affects notmuch-pick so
is relatively safe.
Best wishes
Mark
contrib/notmuch-pick/notmuch-pick.el | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index fbd7c0b..7f5f729 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -817,16 +817,15 @@ Complete list of currently available key bindings:
(if (equal (car (process-lines notmuch-command "count" search-args)) "0")
(setq search-args basic-query))
(if notmuch-pick-asynchronous-parser
- (let ((proc (start-process
- "notmuch-pick" buffer
- notmuch-command "show" "--body=false" "--format=sexp"
+ (let ((proc (notmuch-start-notmuch
+ "notmuch-pick" buffer #'notmuch-pick-process-sentinel
+ "show" "--body=false" "--format=sexp"
message-arg search-args))
;; Use a scratch buffer to accumulate partial output.
;; This buffer will be killed by the sentinel, which
;; should be called no matter how the process dies.
(parse-buf (generate-new-buffer " *notmuch pick parse*")))
(process-put proc 'parse-buf parse-buf)
- (set-process-sentinel proc 'notmuch-pick-process-sentinel)
(set-process-filter proc 'notmuch-pick-process-filter)
(set-process-query-on-exit-flag proc nil))
(progn
--
1.7.9.1
More information about the notmuch
mailing list