[PATCH v6 00/12] insert command
Mark Walters
markwalters1009 at gmail.com
Sat Jun 22 00:55:56 PDT 2013
Overall this series looks very good and my only comments are the ones I
have just sent. There is one trivial bug and we need to decide whether
we need something like --fail-on-index-fail.
Once those are fixed or decided then this series has a +1 from me.
Best wishes
Mark
On Sat, 22 Jun 2013, Peter Wang <novalazy at gmail.com> wrote:
> Since v5:
>
> - return success if the message was successfully added to the maildir
> even if we weren't able to add it to the notmuch database
> - document exit status
> - add a couple of tests
> - don't print anything after parse_arguments returns failure
>
> Peter Wang (12):
> tag-util: move out 'tag' command-line checks
> tag-util: do not reset list in parse_tag_command_line
> cli: add insert command
> man: document 'insert' command
> man: reference notmuch-insert.1
> test: add tests for insert
> insert: add --folder option
> man: document insert --folder option
> test: test insert --folder option
> insert: add --create-folder option
> man: document insert --create-folder
> test: test insert --create-folder option
>
> Makefile.local | 1 +
> man/Makefile.local | 1 +
> man/man1/notmuch-config.1 | 4 +-
> man/man1/notmuch-count.1 | 4 +-
> man/man1/notmuch-dump.1 | 4 +-
> man/man1/notmuch-insert.1 | 75 +++++++
> man/man1/notmuch-new.1 | 4 +-
> man/man1/notmuch-reply.1 | 3 +-
> man/man1/notmuch-restore.1 | 3 +-
> man/man1/notmuch-search.1 | 3 +-
> man/man1/notmuch-show.1 | 3 +-
> man/man1/notmuch-tag.1 | 3 +-
> man/man1/notmuch.1 | 3 +-
> man/man5/notmuch-hooks.5 | 4 +-
> man/man7/notmuch-search-terms.7 | 3 +-
> notmuch-client.h | 3 +
> notmuch-insert.c | 477 ++++++++++++++++++++++++++++++++++++++++
> notmuch-tag.c | 5 +
> notmuch.c | 3 +
> tag-util.c | 8 +-
> tag-util.h | 2 +
> test/insert | 121 ++++++++++
> test/notmuch-test | 1 +
> 23 files changed, 716 insertions(+), 22 deletions(-)
> create mode 100644 man/man1/notmuch-insert.1
> create mode 100644 notmuch-insert.c
> create mode 100755 test/insert
>
> --
> 1.7.12.1
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
More information about the notmuch
mailing list