[PATCH 0/2] Contrib: Pick: Remove horrible hack

Mark Walters markwalters1009 at gmail.com
Sat May 25 23:50:06 PDT 2013


Pick used to have one horrible hack: if the user asked it to open the
first matching message it had to check whether that had arrived (as
the search is asynchronous) and if not wait and try again. Now the
opening of the first matching message is called via the pick process
filter this hack can be removed.

This did reveal the followibg small bug.  Pick shows the subject line
in the output but if it is the same as the previous line (ignoring re:
etc) it shows ... If a single message is refreshed (eg for a tag
update) this was got wrong. The change above triggered this and made
the test fail as the unread tag was removed from the first matching
message when it was displayed.

Patch 2/2 fixes this by storing the previous subject with the search result.

Best wishes

Mark
 

Mark Walters (2):
  contrib: pick: remove hack notmuch-pick-show-match-message-with-wait
  contrib: pick: fix refresh result

 contrib/notmuch-pick/notmuch-pick.el |   60 ++++++++++++++++-----------------
 1 files changed, 29 insertions(+), 31 deletions(-)

-- 
1.7.9.1



More information about the notmuch mailing list