[PATCH] emacs: Compute build dependencies to fix byte compile issues

[David Bremner]

Austin Clements <amdragon at MIT.EDU> writes:
>
> This patch addresses these problems by computing make dependency rules
> from the (require 'x) forms in the Elisp source files, which we inject
> into make's dependency database.

this seems to work as advertised.

> +;;
> +;; Copyright © Austin Clements

I guess you need a copyright year?

> +	    ;; Is it a (require 'x) form?
> +	    (when (and (listp form) (= (length form) 2)
> +		       (eq (car form) 'require)
> +		       (listp (cadr form)) (= (length (cadr form)) 2)
> +		       (eq (car (cadr form)) 'quote)
> +		       (symbolp (cadr (cadr form))))

This might be a corner case, but formally can't the argument to require
be a variable or even a function call? Maybe this never happens in
practice.