[PATCH 1/1] emacs: fixed (declare-function ...) definitions

Tomi Ollila tomi.ollila at iki.fi
Sat Apr 27 02:39:17 PDT 2013


On Sat, Apr 13 2013, David Bremner <david at tethera.net> wrote:

> Mark Walters <markwalters1009 at gmail.com> writes:
>
>> On Wed, 10 Apr 2013, Tomi Ollila <tomi.ollila at iki.fi> wrote:
>>> Some (declare-function ...) definitions were drifted away from the
>>> actual (defun ...)'s. To find the drifts and to verify changes
>>> the following command line was used:
>>>
>>> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'
>>
>> This patch looks good to me +1.
>>
>> Is it worth making the above command into a test?

I attempted to do a test -- failed miserably with test_emacs ()

> Maybe a release check?

You want to delegate the work developers should do to yourself
(if not fixing the things, moan about those ;)

For the time being I drop needs-review tag.

> d

Tomi


More information about the notmuch mailing list