[PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only

Tomi Ollila tomi.ollila at iki.fi
Thu Mar 7 06:38:52 PST 2013


On Thu, Mar 07 2013, David Bremner <david at tethera.net> wrote:

> Jani Nikula <jani at nikula.org> writes:
>
>> We now have a notmuch_config_is_new() function to query whether a
>> config was created or not. Change the notmuch_config_open() is_new
>> parameter into boolean create_new to determine whether the function
>> should create a new config if one doesn't exist. This reduces the
>> complexity of the API.
>
> I have pushed the first 4 patches in this series. I'd like a second
> (third?) pair of eyes on 5/6.

The changes in 5/6 (and 6/6 & manpage) LGTM. Using config for the context
is good. The reply context of this mail has been produced by notmuch
with these patches applied.

> d

Tomi


More information about the notmuch mailing list