[PATCH] string-util: Disallow empty prefixes in parse_boolean_term

Austin Clements amdragon at MIT.EDU
Mon Jan 7 13:20:40 PST 2013


Xapian doesn't consider ":abc" to be a prefixed term.  This makes
parse_boolean_term similarly reject queries with an empty prefix.
---
 util/string-util.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/string-util.c b/util/string-util.c
index aba9aa8..a5622d7 100644
--- a/util/string-util.c
+++ b/util/string-util.c
@@ -127,7 +127,7 @@ parse_boolean_term (void *ctx, const char *str,
     /* Parse prefix */
     str = skip_space (str);
     const char *pos = strchr (str, ':');
-    if (! pos)
+    if (! pos || pos == str)
 	goto FAIL;
     *prefix_out = talloc_strndup (ctx, str, pos - str);
     if (! *prefix_out) {
-- 
1.7.10.4



More information about the notmuch mailing list